Commit 866e5fd8 authored Jul 17, 2019 by Jon Maloy Committed by David S. Miller Jul 17, 2019

tipc: initialize 'validated' field of received packets



The tipc_msg_validate() function leaves a boolean flag 'validated' in
the validated buffer's control block, to avoid performing this action
more than once. However, at reception of new packets, the position of
this field may already have been set by lower layer protocols, so
that the packet is erroneously perceived as already validated by TIPC.

We fix this by initializing the said field to 'false' before performing
the initial validation.

Signed-off-by: Jon Maloy <jon.maloy@ericsson.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 7b379472

net/tipc/node.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -1807,6 +1807,7 @@ void tipc_rcv(struct net net, struct sk_buff skb, struct tipc_bearer *b)
		__skb_queue_head_init(&xmitq);

		/* Ensure message is well-formed before touching the header */
		TIPC_SKB_CB(skb)->validated = false;
		if (unlikely(!tipc_msg_validate(&skb)))
		goto discard;
		hdr = buf_msg(skb);