Commit 864b23f0 authored Sep 06, 2019 by Austin Kim Committed by Ingo Molnar Sep 06, 2019

x86/platform/uv: Fix kmalloc() NULL check routine



The result of kmalloc() should have been checked ahead of below statement:

	pqp = (struct bau_pq_entry *)vp;

Move BUG_ON(!vp) before above statement.

Signed-off-by: Austin Kim <austindh.kim@gmail.com>
Cc: Dimitri Sivanich <dimitri.sivanich@hpe.com>
Cc: Hedi Berriche <hedi.berriche@hpe.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Mike Travis <mike.travis@hpe.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Russ Anderson <russ.anderson@hpe.com>
Cc: Steve Wahl <steve.wahl@hpe.com>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: allison@lohutok.net
Cc: andy@infradead.org
Cc: armijn@tjaldur.nl
Cc: bp@alien8.de
Cc: dvhart@infradead.org
Cc: gregkh@linuxfoundation.org
Cc: hpa@zytor.com
Cc: kjlu@umn.edu
Cc: platform-driver-x86@vger.kernel.org
Link: https://lkml.kernel.org/r/20190905232951.GA28779@LGEARND20B15


Signed-off-by: Ingo Molnar <mingo@kernel.org>

parent f49dcd1a

arch/x86/platform/uv/tlb_uv.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -1804,9 +1804,9 @@ static void pq_init(int node, int pnode)

		plsize = (DEST_Q_SIZE + 1) * sizeof(struct bau_pq_entry);
		vp = kmalloc_node(plsize, GFP_KERNEL, node);
		pqp = (struct bau_pq_entry *)vp;
		BUG_ON(!pqp);
		BUG_ON(!vp);

		pqp = (struct bau_pq_entry *)vp;
		cp = (char *)pqp + 31;
		pqp = (struct bau_pq_entry *)(((unsigned long)cp >> 5) << 5);