Commit 86290591 authored Jul 30, 2020 by Daeho Jeong Committed by Greg Kroah-Hartman Aug 04, 2022

BACKPORT: f2fs: make file immutable even if releasing zero compression block



commit 567c4bf54a85 upstream.

When we use F2FS_IOC_RELEASE_COMPRESS_BLOCKS ioctl, if we can't find
any compressed blocks in the file even with large file size, the
ioctl just ends up without changing the file's status as immutable.
It makes the user, who expects that the file is immutable when it
returns successfully, confused.

Bug: 237904436
Signed-off-by: Daeho Jeong <daehojeong@google.com>
Reviewed-by: Chao Yu <yuchao0@huawei.com>
Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
Change-Id: I2c96428442e69b69c7064096d2e1ce8e2b99cc09

parent 3cf0f824

fs/f2fs/file.c

+3 −3

Original line number	Diff line number	Diff line
		@@ -3528,14 +3528,14 @@ static int f2fs_release_compress_blocks(struct file *filp, unsigned long arg)
		if (ret)
		goto out;

		if (!F2FS_I(inode)->i_compr_blocks)
		goto out;

		F2FS_I(inode)->i_flags \|= F2FS_IMMUTABLE_FL;
		f2fs_set_inode_flags(inode);
		inode->i_ctime = current_time(inode);
		f2fs_mark_inode_dirty_sync(inode, true);

		if (!F2FS_I(inode)->i_compr_blocks)
		goto out;

		down_write(&F2FS_I(inode)->i_gc_rwsem[WRITE]);
		down_write(&F2FS_I(inode)->i_mmap_sem);