Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 85de5d53 authored by Bernard Metzler's avatar Bernard Metzler Committed by Jason Gunthorpe
Browse files

RDMA/siw: Remove unnecessary kthread create/destroy printouts 



There is already a warning if we cannot start any thread, and stopping
those threads is not worth spamming the console.

This also corrects a warning from gcc:

 drivers/infiniband/sw/siw/siw_main.c: In function 'siw_create_tx_threads':
 drivers/infiniband/sw/siw/siw_main.c:91:11: warning:
  variable 'rv' set but not used [-Wunused-but-set-variable]

Reported-by: default avatarHulk Robot <hulkci@huawei.com>
Signed-off-by: default avatarYueHaibing <yuehaibing@huawei.com>
Signed-off-by: default avatarBernard Metzler <bmt@zurich.ibm.com>
Signed-off-by: default avatarJason Gunthorpe <jgg@mellanox.com>
parent 4d2b8517

drivers/infiniband/sw/siw/siw_main.c

+1 −3
Original line number Diff line number Diff line
@@ -88,7 +88,7 @@ static void siw_device_cleanup(struct ib_device *base_dev) 


static int siw_create_tx_threads(void)

{

	int cpu, rv, assigned = 0;

	int cpu, assigned = 0;



	for_each_online_cpu(cpu) {

		/* Skip HT cores */
@@ -99,9 +99,7 @@ static int siw_create_tx_threads(void) 
			kthread_create(siw_run_sq, (unsigned long *)(long)cpu,

				       "siw_tx/%d", cpu);

		if (IS_ERR(siw_tx_thread[cpu])) {

			rv = PTR_ERR(siw_tx_thread[cpu]);

			siw_tx_thread[cpu] = NULL;

			pr_info("Creating TX thread for CPU %d failed", cpu);

			continue;

		}

		kthread_bind(siw_tx_thread[cpu], cpu);

drivers/infiniband/sw/siw/siw_qp_tx.c

+0 −4
Original line number Diff line number Diff line
@@ -1201,8 +1201,6 @@ int siw_run_sq(void *data) 
	init_llist_head(&tx_task->active);

	init_waitqueue_head(&tx_task->waiting);



	pr_info("Started siw TX thread on CPU %u\n", nr_cpu);



	while (1) {

		struct llist_node *fifo_list = NULL;
@@ -1240,8 +1238,6 @@ int siw_run_sq(void *data) 
			siw_sq_resume(qp);

		}

	}

	pr_info("Stopped siw TX thread on CPU %u\n", nr_cpu);



	return 0;

}