Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 85d08340 authored by Dan Carpenter's avatar Dan Carpenter Committed by Jiri Kosina
Browse files

HID: roccat: silence an uninitialized variable warning 



My static checker complains because we use "dev_id" before we check for
errors so it could be uninitialized.  Fix this by moving the error
handling forward a couple lines.

Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarJiri Kosina <jkosina@suse.cz>
parent d66435cc

drivers/hid/hid-roccat.c

+2 −3
Original line number Original line Diff line number Diff line
@@ -421,14 +421,13 @@ static int __init roccat_init(void) 




	retval = alloc_chrdev_region(&dev_id, ROCCAT_FIRST_MINOR,

	retval = alloc_chrdev_region(&dev_id, ROCCAT_FIRST_MINOR,

			ROCCAT_MAX_DEVICES, "roccat");

			ROCCAT_MAX_DEVICES, "roccat");



	roccat_major = MAJOR(dev_id);



	if (retval < 0) {

	if (retval < 0) {

		pr_warn("can't get major number\n");

		pr_warn("can't get major number\n");

		goto error;

		goto error;

	}

	}





	roccat_major = MAJOR(dev_id);



	cdev_init(&roccat_cdev, &roccat_ops);

	cdev_init(&roccat_cdev, &roccat_ops);

	retval = cdev_add(&roccat_cdev, dev_id, ROCCAT_MAX_DEVICES);

	retval = cdev_add(&roccat_cdev, dev_id, ROCCAT_MAX_DEVICES);