Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 85a40bfb authored by Liang He's avatar Liang He Committed by Greg Kroah-Hartman
Browse files

memory: of: Fix refcount leak bug in of_get_ddr_timings() 



[ Upstream commit 05215fb32010d4afb68fbdbb4d237df6e2d4567b ]

We should add the of_node_put() when breaking out of
for_each_child_of_node() as it will automatically increase
and decrease the refcount.

Fixes: e6b42eb6 ("memory: emif: add device tree support to emif driver")
Signed-off-by: default avatarLiang He <windhl@126.com>
Signed-off-by: default avatarKrzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Link: https://lore.kernel.org/r/20220719085640.1210583-1-windhl@126.com


Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent b37f4a71

drivers/memory/of_memory.c

+1 −0
Original line number Diff line number Diff line
@@ -132,6 +132,7 @@ const struct lpddr2_timings *of_get_ddr_timings(struct device_node *np_ddr, 
	for_each_child_of_node(np_ddr, np_tim) {

		if (of_device_is_compatible(np_tim, tim_compat)) {

			if (of_do_get_timings(np_tim, &timings[i])) {

				of_node_put(np_tim);

				devm_kfree(dev, timings);

				goto default_timings;

			}