Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 85088c4a authored by Nitzan Carmi's avatar Nitzan Carmi Committed by Christoph Hellwig
Browse files

nvme: take refcount on transport module 



The block device is backed by the transport so we must ensure that the
transport driver will not be removed until all references are released.
Otherwise, we might end up referencing freed memory.

Reviewed-by: default avatarMax Gurtovoy <maxg@mellanox.com>
Signed-off-by: default avatarNitzan Carmi <nitzanc@mellanox.com>
Signed-off-by: default avatarChristoph Hellwig <hch@lst.de>
parent 2b1b7e78

drivers/nvme/host/core.c

+14 −3
Original line number Diff line number Diff line
@@ -1228,16 +1228,27 @@ static int nvme_open(struct block_device *bdev, fmode_t mode) 
#ifdef CONFIG_NVME_MULTIPATH

	/* should never be called due to GENHD_FL_HIDDEN */

	if (WARN_ON_ONCE(ns->head->disk))

		return -ENXIO;

		goto fail;

#endif

	if (!kref_get_unless_zero(&ns->kref))

		return -ENXIO;

		goto fail;

	if (!try_module_get(ns->ctrl->ops->module))

		goto fail_put_ns;



	return 0;



fail_put_ns:

	nvme_put_ns(ns);

fail:

	return -ENXIO;

}



static void nvme_release(struct gendisk *disk, fmode_t mode)

{

	nvme_put_ns(disk->private_data);

	struct nvme_ns *ns = disk->private_data;



	module_put(ns->ctrl->ops->module);

	nvme_put_ns(ns);

}



static int nvme_getgeo(struct block_device *bdev, struct hd_geometry *geo)