Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 84da9771 authored by Navid Emamdoost's avatar Navid Emamdoost Committed by Greg Kroah-Hartman
Browse files

media: rc: prevent memory leak in cx23888_ir_probe 



[ Upstream commit a7b2df76b42bdd026e3106cf2ba97db41345a177 ]

In cx23888_ir_probe if kfifo_alloc fails the allocated memory for state
should be released.

Signed-off-by: default avatarNavid Emamdoost <navid.emamdoost@gmail.com>
Signed-off-by: default avatarSean Young <sean@mess.org>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab+samsung@kernel.org>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent ecfa7fa1

drivers/media/pci/cx23885/cx23888-ir.c

+4 −1
Original line number Diff line number Diff line
@@ -1167,8 +1167,11 @@ int cx23888_ir_probe(struct cx23885_dev *dev) 
		return -ENOMEM;



	spin_lock_init(&state->rx_kfifo_lock);

	if (kfifo_alloc(&state->rx_kfifo, CX23888_IR_RX_KFIFO_SIZE, GFP_KERNEL))

	if (kfifo_alloc(&state->rx_kfifo, CX23888_IR_RX_KFIFO_SIZE,

			GFP_KERNEL)) {

		kfree(state);

		return -ENOMEM;

	}



	state->dev = dev;

	sd = &state->sd;