Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 84c41742 authored by Andi Kleen's avatar Andi Kleen Committed by Arnaldo Carvalho de Melo
Browse files

perf record: Support direct --user-regs arguments 



USER_REGS can currently only collected implicitely with call graph
recording. Sometimes it is useful to see them separately, and filter
them. Add a new --user-regs option to record that is similar to
--intr-regs, but acts on user regs.

Signed-off-by: default avatarAndi Kleen <ak@linux.intel.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Link: http://lkml.kernel.org/r/20170905170029.19722-1-andi@firstfloor.org


Signed-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
parent b90f1333

tools/perf/Documentation/perf-record.txt

+2 −0
Original line number Diff line number Diff line
@@ -377,6 +377,8 @@ symbolic names, e.g. on x86, ax, si. To list the available registers use 
--intr-regs=\?. To name registers, pass a comma separated list such as

--intr-regs=ax,bx. The list of register is architecture dependent.



--user-regs::

Capture user registers at sample time. Same arguments as -I.



--running-time::

Record running and enabled time for read events (:S)

tools/perf/builtin-record.c

+3 −0
Original line number Diff line number Diff line
@@ -1643,6 +1643,9 @@ static struct option __record_options[] = { 
	OPT_CALLBACK_OPTARG('I', "intr-regs", &record.opts.sample_intr_regs, NULL, "any register",

		    "sample selected machine registers on interrupt,"

		    " use -I ? to list register names", parse_regs),

	OPT_CALLBACK_OPTARG(0, "user-regs", &record.opts.sample_user_regs, NULL, "any register",

		    "sample selected machine registers on interrupt,"

		    " use -I ? to list register names", parse_regs),

	OPT_BOOLEAN(0, "running-time", &record.opts.running_time,

		    "Record running/enabled time of read (:S) events"),

	OPT_CALLBACK('k', "clockid", &record.opts,

tools/perf/perf.h

+1 −0
Original line number Diff line number Diff line
@@ -65,6 +65,7 @@ struct record_opts { 
	unsigned int user_freq;

	u64          branch_stack;

	u64	     sample_intr_regs;

	u64	     sample_user_regs;

	u64	     default_interval;

	u64	     user_interval;

	size_t	     auxtrace_snapshot_size;

tools/perf/util/evsel.c

+6 −1
Original line number Diff line number Diff line
@@ -678,7 +678,7 @@ void perf_evsel__config_callchain(struct perf_evsel *evsel, 
		if (!function) {

			perf_evsel__set_sample_bit(evsel, REGS_USER);

			perf_evsel__set_sample_bit(evsel, STACK_USER);

			attr->sample_regs_user = PERF_REGS_MASK;

			attr->sample_regs_user |= PERF_REGS_MASK;

			attr->sample_stack_user = param->dump_size;

			attr->exclude_callchain_user = 1;

		} else {
@@ -931,6 +931,11 @@ void perf_evsel__config(struct perf_evsel *evsel, struct record_opts *opts, 
		perf_evsel__set_sample_bit(evsel, REGS_INTR);

	}



	if (opts->sample_user_regs) {

		attr->sample_regs_user |= opts->sample_user_regs;

		perf_evsel__set_sample_bit(evsel, REGS_USER);

	}



	if (target__has_cpu(&opts->target) || opts->sample_cpu)

		perf_evsel__set_sample_bit(evsel, CPU);