Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 84b0a4f4 authored by Changming Liu's avatar Changming Liu Committed by Greg Kroah-Hartman
Browse files

ALSA: hwdep: fix a left shifting 1 by 31 UB bug 



[ Upstream commit fb8cd6481ffd126f35e9e146a0dcf0c4e8899f2e ]

The "info.index" variable can be 31 in "1 << info.index".
This might trigger an undefined behavior since 1 is signed.

Fix this by casting 1 to 1u just to be sure "1u << 31" is defined.

Signed-off-by: default avatarChangming Liu <liu.changm@northeastern.edu>
Cc: <stable@vger.kernel.org>
Link: https://lore.kernel.org/r/BL0PR06MB4548170B842CB055C9AF695DE5B00@BL0PR06MB4548.namprd06.prod.outlook.com


Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent a003e1f6

sound/core/hwdep.c

+2 −2
Original line number Diff line number Diff line
@@ -216,12 +216,12 @@ static int snd_hwdep_dsp_load(struct snd_hwdep *hw, 
	if (info.index >= 32)

		return -EINVAL;

	/* check whether the dsp was already loaded */

	if (hw->dsp_loaded & (1 << info.index))

	if (hw->dsp_loaded & (1u << info.index))

		return -EBUSY;

	err = hw->ops.dsp_load(hw, &info);

	if (err < 0)

		return err;

	hw->dsp_loaded |= (1 << info.index);

	hw->dsp_loaded |= (1u << info.index);

	return 0;

}