Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 84557783 authored by Jesper Juhl's avatar Jesper Juhl Committed by David S. Miller
Browse files

isdn: eicon: free pointer after using it in log msg in divas_um_idi_delete_entity() 



Not really a problem, but nice IMHO; the Coverity static analyzer
complains that we use the pointer 'e' after it has been freed, so move
the freeing below the final use, even if that use is just using the
value of the pointer and not actually dereferencing it.

Signed-off-by: default avatarJesper Juhl <jj@chaosbits.net>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 99d3d587

drivers/isdn/hardware/eicon/um_idi.c

+1 −1
Original line number Original line Diff line number Diff line
@@ -288,9 +288,9 @@ int divas_um_idi_delete_entity(int adapter_nr, void *entity) 
	cleanup_entity(e);

	cleanup_entity(e);

	diva_os_free(0, e->os_context);

	diva_os_free(0, e->os_context);

	memset(e, 0x00, sizeof(*e));

	memset(e, 0x00, sizeof(*e));

	diva_os_free(0, e);





	DBG_LOG(("A(%d) remove E:%08x", adapter_nr, e));

	DBG_LOG(("A(%d) remove E:%08x", adapter_nr, e));

	diva_os_free(0, e);





	return (0);

	return (0);

}

}