Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 843ff688 authored by Colin Ian King's avatar Colin Ian King Committed by Greg Kroah-Hartman
Browse files

media: em28xx: Don't use ops->suspend if it is NULL 



[ Upstream commit 51fa3b70d27342baf1ea8aaab3e96e5f4f26d5b2 ]

The call to ops->suspend for the dev->dev_next case can currently
trigger a call on a null function pointer if ops->suspend is null.
Skip over the use of function ops->suspend if it is null.

Addresses-Coverity: ("Dereference after null check")

Fixes: be7fd3c3 ("media: em28xx: Hauppauge DualHD second tuner functionality")
Signed-off-by: default avatarColin Ian King <colin.king@canonical.com>
Signed-off-by: default avatarHans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab+huawei@kernel.org>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent e577924b

drivers/media/usb/em28xx/em28xx-core.c

+3 −2
Original line number Diff line number Diff line
@@ -1152,7 +1152,8 @@ int em28xx_suspend_extension(struct em28xx *dev) 
	dev_info(&dev->intf->dev, "Suspending extensions\n");

	mutex_lock(&em28xx_devlist_mutex);

	list_for_each_entry(ops, &em28xx_extension_devlist, next) {

		if (ops->suspend)

		if (!ops->suspend)

			continue;

		ops->suspend(dev);

		if (dev->dev_next)

			ops->suspend(dev->dev_next);