Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 84274458 authored by Sven Eckelmann's avatar Sven Eckelmann Committed by Simon Wunderlich
Browse files

batman-adv: Place kref_get for neigh_node near use 



It is hard to understand why the refcnt is increased when it isn't done
near the actual place the new reference is used. So using kref_get right
before the place which requires the reference and in the same function
helps to avoid accidental problems caused by incorrect reference counting.

Signed-off-by: default avatarSven Eckelmann <sven@narfation.org>
Signed-off-by: default avatarMarek Lindner <mareklindner@neomailbox.ch>
Signed-off-by: default avatarSimon Wunderlich <sw@simonwunderlich.de>
parent 2e774ac2

net/batman-adv/originator.c

+1 −1
Original line number Diff line number Diff line
@@ -654,8 +654,8 @@ batadv_neigh_node_create(struct batadv_orig_node *orig_node, 


	/* extra reference for return */

	kref_init(&neigh_node->refcount);

	kref_get(&neigh_node->refcount);



	kref_get(&neigh_node->refcount);

	hlist_add_head_rcu(&neigh_node->list, &orig_node->neigh_list);



	batadv_dbg(BATADV_DBG_BATMAN, orig_node->bat_priv,