Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 841f5b23 authored by Bharata B Rao's avatar Bharata B Rao Committed by Greg Kroah-Hartman
Browse files

sched/debug: Remove mpol_get/put and task_lock/unlock from sched_show_numa 



[ Upstream commit 28c988c3ec29db74a1dda631b18785958d57df4f ]

The older format of /proc/pid/sched printed home node info which
required the mempolicy and task lock around mpol_get(). However
the format has changed since then and there is no need for
sched_show_numa() any more to have mempolicy argument,
asssociated mpol_get/put and task_lock/unlock. Remove them.

Fixes: 397f2378 ("sched/numa: Fix numa balancing stats in /proc/pid/sched")
Signed-off-by: default avatarBharata B Rao <bharata@amd.com>
Signed-off-by: default avatarPeter Zijlstra (Intel) <peterz@infradead.org>
Reviewed-by: default avatarSrikar Dronamraju <srikar@linux.vnet.ibm.com>
Acked-by: default avatarMel Gorman <mgorman@suse.de>
Link: https://lore.kernel.org/r/20220118050515.2973-1-bharata@amd.com


Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent 715a3431

kernel/sched/debug.c

+0 −10
Original line number Diff line number Diff line
@@ -847,25 +847,15 @@ void print_numa_stats(struct seq_file *m, int node, unsigned long tsf, 
static void sched_show_numa(struct task_struct *p, struct seq_file *m)

{

#ifdef CONFIG_NUMA_BALANCING

	struct mempolicy *pol;



	if (p->mm)

		P(mm->numa_scan_seq);



	task_lock(p);

	pol = p->mempolicy;

	if (pol && !(pol->flags & MPOL_F_MORON))

		pol = NULL;

	mpol_get(pol);

	task_unlock(p);



	P(numa_pages_migrated);

	P(numa_preferred_nid);

	P(total_numa_faults);

	SEQ_printf(m, "current_node=%d, numa_group_id=%d\n",

			task_node(p), task_numa_group_id(p));

	show_numa_stats(p, m);

	mpol_put(pol);

#endif

}