Commit 83e418a8 authored Feb 09, 2019 by Martin Blumenstingl Committed by Ulf Hansson Feb 13, 2019

mmc: meson-gx: fix interrupt name



Commit bb364890 ("mmc: meson-gx: Free irq in release() callback")
changed the _probe code to use request_threaded_irq() instead of
devm_request_threaded_irq().
Unfortunately this removes a fallback for the interrupt name:
devm_request_threaded_irq() uses the device name as fallback if the
given IRQ name is NULL. request_threaded_irq() has no such fallback,
thus /proc/interrupts shows "(null)" instead.

Explicitly pass the dev_name() so we get the IRQ name shown in
/proc/interrupts again.
While here, also fix the indentation of the request_threaded_irq()
parameter list.

Fixes: bb364890 ("mmc: meson-gx: Free irq in release() callback")
Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>

parent dcf6e2e3

drivers/mmc/host/meson-gx-mmc.c

+2 −1

Original line number	Diff line number	Diff line
		@@ -1338,7 +1338,8 @@ static int meson_mmc_probe(struct platform_device *pdev)
		host->regs + SD_EMMC_IRQ_EN);

		ret = request_threaded_irq(host->irq, meson_mmc_irq,
		meson_mmc_irq_thread, IRQF_SHARED, NULL, host);
		meson_mmc_irq_thread, IRQF_SHARED,
		dev_name(&pdev->dev), host);
		if (ret)
		goto err_init_clk;