Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 83444516 authored by Zhengchao Shao's avatar Zhengchao Shao Committed by Greg Kroah-Hartman
Browse files

net: cpsw: disable napi in cpsw_ndo_open() 



[ Upstream commit 6d47b53fb3f363a74538a1dbd09954af3d8d4131 ]

When failed to create xdp rxqs or fill rx channels in cpsw_ndo_open() for
opening device, napi isn't disabled. When open cpsw device next time, it
will report a invalid opcode issue. Compiled tested only.

Fixes: d354eb85 ("drivers: net: cpsw: dual_emac: simplify napi usage")
Signed-off-by: default avatarZhengchao Shao <shaozhengchao@huawei.com>
Link: https://lore.kernel.org/r/20221109011537.96975-1-shaozhengchao@huawei.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent 3892c2d3

drivers/net/ethernet/ti/cpsw.c

+2 −0
Original line number Diff line number Diff line
@@ -1753,6 +1753,8 @@ static int cpsw_ndo_open(struct net_device *ndev) 


err_cleanup:

	if (!cpsw->usage_count) {

		napi_disable(&cpsw->napi_rx);

		napi_disable(&cpsw->napi_tx);

		cpdma_ctlr_stop(cpsw->dma);

		cpsw_destroy_xdp_rxqs(cpsw);

	}