Commit 8321652a authored Sep 13, 2012 by Alexey Khoroshilov Committed by Greg Kroah-Hartman Sep 13, 2012

USB: omninet: fix potential tty NULL dereference



Add check for return value of tty_port_tty_get,
since it can return NULL after port hangup that may happen anytime.

Found by Linux Driver Verification project (linuxtesting.org).

Signed-off-by: Alexey Khoroshilov <khoroshilov@ispras.ru>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 17e67910

drivers/usb/serial/omninet.c

+5 −3

Original line number	Diff line number	Diff line
		@@ -185,11 +185,13 @@ static void omninet_read_bulk_callback(struct urb *urb)

		if (urb->actual_length && header->oh_len) {
		struct tty_struct *tty = tty_port_tty_get(&port->port);
		if (tty) {
		tty_insert_flip_string(tty, data + OMNINET_DATAOFFSET,
		header->oh_len);
		tty_flip_buffer_push(tty);
		tty_kref_put(tty);
		}
		}

		/* Continue trying to always read */
		result = usb_submit_urb(urb, GFP_ATOMIC);