Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 83094ebc authored by Ido Schimmel's avatar Ido Schimmel Committed by Greg Kroah-Hartman
Browse files

mlxsw: spectrum_router: Remove unlikely user-triggerable warning 



[ Upstream commit 62201c00c4679ad8f0730d6d925a5d23651dfad2 ]

In case the driver vetoes the addition of an IPv6 multipath route, the
IPv6 stack will emit delete notifications for the sibling routes that
were already added to the FIB trie. Since these siblings are not present
in hardware, a warning will be generated.

Have the driver ignore notifications for routes it does not have.

Fixes: ebee3cad ("ipv6: Add IPv6 multipath notifications for add / replace")
Signed-off-by: default avatarIdo Schimmel <idosch@mellanox.com>
Acked-by: default avatarJiri Pirko <jiri@mellanox.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 95b211b2

drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c

+6 −1
Original line number Diff line number Diff line
@@ -5637,8 +5637,13 @@ static void mlxsw_sp_router_fib6_del(struct mlxsw_sp *mlxsw_sp, 
	if (mlxsw_sp_fib6_rt_should_ignore(rt))

		return;



	/* Multipath routes are first added to the FIB trie and only then

	 * notified. If we vetoed the addition, we will get a delete

	 * notification for a route we do not have. Therefore, do not warn if

	 * route was not found.

	 */

	fib6_entry = mlxsw_sp_fib6_entry_lookup(mlxsw_sp, rt);

	if (WARN_ON(!fib6_entry))

	if (!fib6_entry)

		return;



	/* If not all the nexthops are deleted, then only reduce the nexthop