Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 82d7669d authored by Steven Toth's avatar Steven Toth Committed by Mauro Carvalho Chehab
Browse files

V4L/DVB (9173): S2API: Remove the hardcoded command limit during validation 



This means that when developers add new commands then they'll be see
the DTV_MAX_COMMAND define and will be more likely to modify it, without
having to modify the command validation code.

Signed-off-by: default avatarSteven Toth <stoth@linuxtv.org>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@redhat.com>
parent e5cefa82

drivers/media/dvb/dvb-core/dvb_frontend.c

+1 −2
Original line number Diff line number Diff line
@@ -848,8 +848,7 @@ void dtv_property_dump(struct dtv_property *tvp) 
{

	int i;



	if( (tvp->cmd <= 0 || tvp->cmd > DTV_DELIVERY_SYSTEM) &&

			tvp->cmd != DTV_API_VERSION) {

	if (tvp->cmd <= 0 || tvp->cmd > DTV_MAX_COMMAND) {

		printk("%s: tvp.cmd = 0x%08x (undefined/unknown/invalid)\n",

			__func__, tvp->cmd);

		return;

include/linux/dvb/frontend.h

+2 −0
Original line number Diff line number Diff line
@@ -270,6 +270,8 @@ struct dvb_frontend_event { 


#define DTV_API_VERSION				35



#define DTV_MAX_COMMAND				DTV_API_VERSION



typedef enum fe_pilot {

	PILOT_ON,

	PILOT_OFF,