Commit 827139ad authored Jun 13, 2020 by Vasily Averin Committed by Greg Kroah-Hartman Jul 22, 2020

tpm_tis: extra chip->ops check on error path in tpm_tis_core_init



[ Upstream commit ccf6fb858e17a8f8a914a1c6444d277cfedfeae6 ]

Found by smatch:
drivers/char/tpm/tpm_tis_core.c:1088 tpm_tis_core_init() warn:
 variable dereferenced before check 'chip->ops' (see line 979)

'chip->ops' is assigned in the beginning of function
in tpmm_chip_alloc->tpm_chip_alloc
and is used before first possible goto to error path.

Signed-off-by: Vasily Averin <vvs@virtuozzo.com>
Reviewed-by: Jerry Snitselaar <jsnitsel@redhat.com>
Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
Signed-off-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent a8f13826

drivers/char/tpm/tpm_tis_core.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -1006,7 +1006,7 @@ int tpm_tis_core_init(struct device dev, struct tpm_tis_data priv, int irq,

		return 0;
		out_err:
		if ((chip->ops != NULL) && (chip->ops->clk_enable != NULL))
		if (chip->ops->clk_enable != NULL)
		chip->ops->clk_enable(chip, false);

		tpm_tis_remove(chip);