Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 824b167f authored by Bjorn Andersson's avatar Bjorn Andersson Committed by Greg Kroah-Hartman
Browse files

rpmsg: glink: Avoid infinite loop on intent for missing channel 



[ Upstream commit 3e74ec2f39362bffbd42854acbb67c7f4cb808f9 ]

In the event that an intent advertisement arrives on an unknown channel
the fifo is not advanced, resulting in the same message being handled
over and over.

Fixes: dacbb35e ("rpmsg: glink: Receive and store the remote intent buffers")
Signed-off-by: default avatarBjorn Andersson <quic_bjorande@quicinc.com>
Reviewed-by: default avatarChris Lew <quic_clew@quicinc.com>
Signed-off-by: default avatarBjorn Andersson <andersson@kernel.org>
Link: https://lore.kernel.org/r/20230214234231.2069751-1-quic_bjorande@quicinc.com


Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent a41bb59e

drivers/rpmsg/qcom_glink_native.c

+1 −0
Original line number Diff line number Diff line
@@ -929,6 +929,7 @@ static void qcom_glink_handle_intent(struct qcom_glink *glink, 
	spin_unlock_irqrestore(&glink->idr_lock, flags);

	if (!channel) {

		dev_err(glink->dev, "intents for non-existing channel\n");

		qcom_glink_rx_advance(glink, ALIGN(msglen, 8));

		return;

	}