Commit 817bedcd authored Nov 23, 2023 by Zhengchao Shao Committed by Greg Kroah-Hartman Feb 23, 2024

bonding: remove print in bond_verify_device_path

commit 486058f42a4728053ae69ebbf78e9731d8ce6f8b upstream.

As suggested by Paolo in link[1], if the memory allocation fails, the mm
layer will emit a lot warning comprising the backtrace, so remove the
print.

[1] https://lore.kernel.org/all/20231118081653.1481260-1-shaozhengchao@huawei.com/



Suggested-by: Paolo Abeni <pabeni@redhat.com>
Signed-off-by: Zhengchao Shao <shaozhengchao@huawei.com>
Reviewed-by: Hangbin Liu <liuhangbin@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent e9512069

drivers/net/bonding/bond_main.c

+1 −4

Original line number	Diff line number	Diff line
		@@ -2482,11 +2482,8 @@ struct bond_vlan_tag bond_verify_device_path(struct net_device start_dev,

		if (start_dev == end_dev) {
		tags = kcalloc(level + 1, sizeof(*tags), GFP_ATOMIC);
		if (!tags) {
		net_err_ratelimited("%s: %s: Failed to allocate tags\n",
		__func__, start_dev->name);
		if (!tags)
		return ERR_PTR(-ENOMEM);
		}
		tags[level].vlan_proto = VLAN_N_VID;
		return tags;
		}