Commit 817b89be authored Aug 15, 2018 by Jesper Dangaard Brouer Committed by Daniel Borkmann Aug 16, 2018

samples/bpf: all XDP samples should unload xdp/bpf prog on SIGTERM



It is common XDP practice to unload/deattach the XDP bpf program,
when the XDP sample program is Ctrl-C interrupted (SIGINT) or
killed (SIGTERM).

The samples/bpf programs xdp_redirect_cpu and xdp_rxq_info,
forgot to trap signal SIGTERM (which is the default signal used
by the kill command).

This was discovered by Red Hat QA, which automated scripts depend
on killing the XDP sample program after a timeout period.

Fixes: fad3917e ("samples/bpf: add cpumap sample program xdp_redirect_cpu")
Fixes: 0fca931a ("samples/bpf: program demonstrating access to xdp_rxq_info")
Reported-by: Jean-Tsung Hsiao <jhsiao@redhat.com>
Signed-off-by: Jesper Dangaard Brouer <brouer@redhat.com>
Acked-by: Yonghong Song <yhs@fb.com>
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>

parent 21b172ee

samples/bpf/xdp_redirect_cpu_user.c

+2 −1

Original line number	Diff line number	Diff line
		@@ -679,8 +679,9 @@ int main(int argc, char **argv)
		return EXIT_FAIL_OPTION;
		}

		/* Remove XDP program when program is interrupted */
		/* Remove XDP program when program is interrupted or killed */
		signal(SIGINT, int_exit);
		signal(SIGTERM, int_exit);

		if (bpf_set_link_xdp_fd(ifindex, prog_fd[prog_num], xdp_flags) < 0) {
		fprintf(stderr, "link set xdp fd failed\n");

samples/bpf/xdp_rxq_info_user.c

+2 −1

Original line number	Diff line number	Diff line
		@@ -567,8 +567,9 @@ int main(int argc, char **argv)
		exit(EXIT_FAIL_BPF);
		}

		/* Remove XDP program when program is interrupted */
		/* Remove XDP program when program is interrupted or killed */
		signal(SIGINT, int_exit);
		signal(SIGTERM, int_exit);

		if (bpf_set_link_xdp_fd(ifindex, prog_fd, xdp_flags) < 0) {
		fprintf(stderr, "link set xdp fd failed\n");