Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 813b0f3e authored by Daniel Vetter's avatar Daniel Vetter
Browse files

drm: Remove crtc/connector->save/restore hooks 



They're not how system suspend/resume should be done with atomic
(there's new helpers for that developed by Thierry Reding), and for
legacy drivers this really should be a helper hook and not a core one.

But there's not even helper code to use them, and only 2 drivers
(which now have their own private hooks) set them. Ditch them.

Saves me typing some kerneldoc, too ;-)

Signed-off-by: default avatarDaniel Vetter <daniel.vetter@intel.com>
Link: http://patchwork.freedesktop.org/patch/msgid/1449218769-16577-15-git-send-email-daniel.vetter@ffwll.ch


Reviewed-by: default avatarThierry Reding <treding@nvidia.com>
parent 2c3d7715

include/drm/drm_crtc.h

+0 −11
Original line number Diff line number Diff line
@@ -320,8 +320,6 @@ struct drm_crtc_state { 


/**

 * struct drm_crtc_funcs - control CRTCs for a given device

 * @save: save CRTC state

 * @restore: restore CRTC state

 * @cursor_set: setup the cursor

 * @cursor_set2: setup the cursor with hotspot, superseeds @cursor_set if set

 * @cursor_move: move the cursor
@@ -339,11 +337,6 @@ struct drm_crtc_state { 
 * bus accessors.

 */

struct drm_crtc_funcs {

	/* Save CRTC state */

	void (*save)(struct drm_crtc *crtc); /* suspend? */

	/* Restore CRTC state */

	void (*restore)(struct drm_crtc *crtc); /* resume? */



	/**

	 * @reset:

	 *
@@ -625,8 +618,6 @@ struct drm_connector_state { 
/**

 * struct drm_connector_funcs - control connectors on a given device

 * @dpms: set power state

 * @save: save connector state

 * @restore: restore connector state

 * @detect: is this connector active?

 * @fill_modes: fill mode list for this connector

 * @force: notify the driver that the connector is forced on
@@ -637,8 +628,6 @@ struct drm_connector_state { 
 */

struct drm_connector_funcs {

	int (*dpms)(struct drm_connector *connector, int mode);

	void (*save)(struct drm_connector *connector);

	void (*restore)(struct drm_connector *connector);



	/**

	 * @reset: