Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 81255d86 authored by Sergio Paracuellos's avatar Sergio Paracuellos Committed by Greg Kroah-Hartman
Browse files

staging: ks7010: refactor ks_wlan_set_phy_type function 



Handle invalid values first and assign good ones at the
end if it is the case. This makes code simplier.

Signed-off-by: default avatarSergio Paracuellos <sergio.paracuellos@gmail.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 7f3c8bb5

drivers/staging/ks7010/ks_wlan_net.c

+6 −9
Original line number Diff line number Diff line
@@ -1960,17 +1960,14 @@ static int ks_wlan_set_phy_type(struct net_device *dev, 


	if (priv->sleep_mode == SLP_SLEEP)

		return -EPERM;

	/* for SLEEP MODE */

	if (*uwrq == D_11B_ONLY_MODE) {	/* 0 */

		priv->reg.phy_type = D_11B_ONLY_MODE;

	} else if (*uwrq == D_11G_ONLY_MODE) {	/* 1 */

		priv->reg.phy_type = D_11G_ONLY_MODE;

	} else if (*uwrq == D_11BG_COMPATIBLE_MODE) {	/* 2 */

		priv->reg.phy_type = D_11BG_COMPATIBLE_MODE;

	} else {



	if (*uwrq != D_11B_ONLY_MODE &&

	    *uwrq != D_11G_ONLY_MODE &&

	    *uwrq != D_11BG_COMPATIBLE_MODE)

		return -EINVAL;

	}



	/* for SLEEP MODE */

	priv->reg.phy_type = *uwrq;

	priv->need_commit |= SME_MODE_SET;

	return -EINPROGRESS;	/* Call commit handler */

}