Unverified Commit 811ba489 authored Jul 24, 2019 by Nishka Dasgupta Committed by Mark Brown Aug 01, 2019

regulator: of: Add of_node_put() before return in function



The local variable search in regulator_of_get_init_node takes the value
returned by either of_get_child_by_name or of_node_get, both of which
get a node. If this node is not put before returning, it could cause a
memory leak. Hence put search before a mid-loop return statement.
Issue found with Coccinelle.

Signed-off-by: Nishka Dasgupta <nishkadg.linux@gmail.com>
Link: https://lore.kernel.org/r/20190724083231.10276-1-nishkadg.linux@gmail.com


Signed-off-by: Mark Brown <broonie@kernel.org>

parent a853c0a0

drivers/regulator/of_regulator.c

+3 −1

Original line number	Diff line number	Diff line
		@@ -416,9 +416,11 @@ device_node regulator_of_get_init_node(struct device dev,
		if (!name)
		name = child->name;

		if (!strcmp(desc->of_match, name))
		if (!strcmp(desc->of_match, name)) {
		of_node_put(search);
		return of_node_get(child);
		}
		}

		of_node_put(search);