Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 8116acce authored by Wei Yongjun's avatar Wei Yongjun Committed by Bjorn Helgaas
Browse files

PCI: keystone: Propagate request_irq() failure 



Previously, if request_irq() failed, ks_add_pcie_port() always returned
zero (success).  Return the request_irq() failure result instead.

[bhelgaas: changelog]
Signed-off-by: default avatarWei Yongjun <weiyj.lk@gmail.com>
Signed-off-by: default avatarBjorn Helgaas <bhelgaas@google.com>
Acked-By: default avatarMurali Karicheri <m-karicheri2@ti.com>
parent 29b4817d

drivers/pci/host/pci-keystone.c

+3 −2
Original line number Diff line number Diff line
@@ -334,8 +334,9 @@ static int __init ks_add_pcie_port(struct keystone_pcie *ks_pcie, 
	if (ks_pcie->error_irq <= 0)

		dev_info(&pdev->dev, "no error IRQ defined\n");

	else {

		if (request_irq(ks_pcie->error_irq, pcie_err_irq_handler,

				IRQF_SHARED, "pcie-error-irq", ks_pcie) < 0) {

		ret = request_irq(ks_pcie->error_irq, pcie_err_irq_handler,

				  IRQF_SHARED, "pcie-error-irq", ks_pcie);

		if (ret < 0) {

			dev_err(&pdev->dev, "failed to request error IRQ %d\n",

				ks_pcie->error_irq);

			return ret;