Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 80753cdf authored by Markus Elfring's avatar Markus Elfring Committed by Takashi Iwai
Browse files

ALSA: us122l: Use common error handling code in us122l_create_card() 



Add a jump target so that a bit of exception handling can be better reused
at the end of this function.

This issue was detected by using the Coccinelle software.

Signed-off-by: default avatarMarkus Elfring <elfring@users.sourceforge.net>
Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
parent e35e9ddf

sound/usb/usx2y/us122l.c

+6 −4
Original line number Diff line number Diff line
@@ -508,8 +508,7 @@ static bool us122l_create_card(struct snd_card *card) 
		err = us122l_create_usbmidi(card);

	if (err < 0) {

		snd_printk(KERN_ERR "us122l_create_usbmidi error %i \n", err);

		us122l_stop(us122l);

		return false;

		goto stop;

	}

	err = usb_stream_hwdep_new(card);

	if (err < 0) {
@@ -518,10 +517,13 @@ static bool us122l_create_card(struct snd_card *card) 
		list_for_each(p, &us122l->midi_list)

			snd_usbmidi_disconnect(p);



		us122l_stop(us122l);

		return false;

		goto stop;

	}

	return true;



stop:

	us122l_stop(us122l);

	return false;

}



static void snd_us122l_free(struct snd_card *card)