Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 8006e373 authored by Igor Russkikh's avatar Igor Russkikh Committed by David S. Miller
Browse files

net: aquantia: fixed instack structure overflow 



This is a real stack undercorruption found by kasan build.

The issue did no harm normally because it only overflowed
2 bytes after `bitary` array which on most architectures
were mapped into `err` local.

Fixes: bab6de8f ("net: ethernet: aquantia: Atlantic A0 and B0 specific functions.")
Signed-off-by: default avatarNikita Danilov <nikita.danilov@aquantia.com>
Signed-off-by: default avatarIgor Russkikh <igor.russkikh@aquantia.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 13b7997a

drivers/net/ethernet/aquantia/atlantic/hw_atl/hw_atl_a0.c

+2 −2
Original line number Diff line number Diff line
@@ -207,7 +207,7 @@ static int hw_atl_a0_hw_rss_set(struct aq_hw_s *self, 
	u32 i = 0U;

	u32 num_rss_queues = max(1U, self->aq_nic_cfg->num_rss_queues);

	int err = 0;

	u16 bitary[(HW_ATL_A0_RSS_REDIRECTION_MAX *

	u16 bitary[1 + (HW_ATL_A0_RSS_REDIRECTION_MAX *

		   HW_ATL_A0_RSS_REDIRECTION_BITS / 16U)];



	memset(bitary, 0, sizeof(bitary));

drivers/net/ethernet/aquantia/atlantic/hw_atl/hw_atl_b0.c

+2 −2
Original line number Diff line number Diff line
@@ -199,7 +199,7 @@ static int hw_atl_b0_hw_rss_set(struct aq_hw_s *self, 
	u32 i = 0U;

	u32 num_rss_queues = max(1U, self->aq_nic_cfg->num_rss_queues);

	int err = 0;

	u16 bitary[(HW_ATL_B0_RSS_REDIRECTION_MAX *

	u16 bitary[1 + (HW_ATL_B0_RSS_REDIRECTION_MAX *

		   HW_ATL_B0_RSS_REDIRECTION_BITS / 16U)];



	memset(bitary, 0, sizeof(bitary));