Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 7f822c80 authored by Andy Shevchenko's avatar Andy Shevchenko Committed by Greg Kroah-Hartman
Browse files

pinctrl: cherryview: Return correct value if pin in push-pull mode 



[ Upstream commit 5835196a17be5cfdcad0b617f90cf4abe16951a4 ]

Currently the getter returns ENOTSUPP on pin configured in
the push-pull mode. Fix this by adding the missed switch case.

Fixes: ccdf81d0 ("pinctrl: cherryview: add option to set open-drain pin config")
Fixes: 6e08d6bb ("pinctrl: Add Intel Cherryview/Braswell pin controller support")
Acked-by: default avatarMika Westerberg <mika.westerberg@linux.intel.com>
Signed-off-by: default avatarAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent 1768e362

drivers/pinctrl/intel/pinctrl-cherryview.c

+10 −5
Original line number Diff line number Diff line
@@ -1021,11 +1021,6 @@ static int chv_config_get(struct pinctrl_dev *pctldev, unsigned int pin, 


		break;



	case PIN_CONFIG_DRIVE_OPEN_DRAIN:

		if (!(ctrl1 & CHV_PADCTRL1_ODEN))

			return -EINVAL;

		break;



	case PIN_CONFIG_BIAS_HIGH_IMPEDANCE: {

		u32 cfg;
@@ -1035,6 +1030,16 @@ static int chv_config_get(struct pinctrl_dev *pctldev, unsigned int pin, 
			return -EINVAL;



		break;



	case PIN_CONFIG_DRIVE_PUSH_PULL:

		if (ctrl1 & CHV_PADCTRL1_ODEN)

			return -EINVAL;

		break;



	case PIN_CONFIG_DRIVE_OPEN_DRAIN:

		if (!(ctrl1 & CHV_PADCTRL1_ODEN))

			return -EINVAL;

		break;

	}



	default: