Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 7f12131e authored by Sai Krishna Juturi's avatar Sai Krishna Juturi Committed by Gerrit - the friendly Code Review server
Browse files

usb : dwc3: Initialize kernel stack variables properly 



If kernel stack variables are not initialized properly,
there  is a chance of kernel information disclosure.
So, initialize kernel stack variables with null characters.

CRs-fixed: 2042592
Change-Id: I213c0e5c7f67824c2cecace276ff2f8f81599d51
Signed-off-by: default avatarSai Krishna Juturi <jsaikrishna@codeaurora.org>
Signed-off-by: default avatarMayank Rana <mrana@codeaurora.org>
Signed-off-by: default avatarSriharsha Allenki <sallenki@codeaurora.org>
parent 243513a6

drivers/usb/dwc3/debugfs.c

+3 −3
Original line number Diff line number Diff line
@@ -423,7 +423,7 @@ static ssize_t dwc3_mode_write(struct file *file, 
	struct seq_file		*s = file->private_data;

	struct dwc3		*dwc = s->private;

	u32			mode = 0;

	char			buf[32];

	char			buf[32] = {};



	if (copy_from_user(&buf, ubuf, min_t(size_t, sizeof(buf) - 1, count)))

		return -EFAULT;
@@ -500,7 +500,7 @@ static ssize_t dwc3_testmode_write(struct file *file, 
	struct dwc3		*dwc = s->private;

	unsigned long		flags;

	u32			testmode = 0;

	char			buf[32];

	char			buf[32] = {};



	if (copy_from_user(&buf, ubuf, min_t(size_t, sizeof(buf) - 1, count)))

		return -EFAULT;
@@ -573,7 +573,7 @@ static ssize_t dwc3_link_state_write(struct file *file, 
	struct dwc3		*dwc = s->private;

	unsigned long		flags;

	enum dwc3_link_state	state = 0;

	char			buf[32];

	char			buf[32] = {};

	u32			reg;

	u8			speed;