Commit 7ef75875 authored Jun 24, 2019 by Colin Ian King Committed by Jason Gunthorpe Jun 25, 2019

RDMA/hns: fix potential integer overflow on left shift

There is a potential integer overflow when int i is left shifted as this
is evaluated using 32 bit arithmetic but is being used in a context that
expects an expression of type dma_addr_t. Fix this by casting integer i
to dma_addr_t before shifting to avoid the overflow.

Addresses-Coverity: ("Unintentional integer overflow")
Fixes: 2ac0bc5e ("RDMA/hns: Add a group interfaces for optimizing buffers getting flow")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>

parent 7796d2a3

drivers/infiniband/hw/hns/hns_roce_alloc.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -257,7 +257,7 @@ int hns_roce_get_kmem_bufs(struct hns_roce_dev hr_dev, dma_addr_t bufs,
		for (i = start; i < end; i++)
		if (buf->nbufs == 1)
		bufs[total++] = buf->direct.map +
		(i << buf->page_shift);
		((dma_addr_t)i << buf->page_shift);
		else
		bufs[total++] = buf->page_list[i].map;