Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 7ed37be3 authored by Zhu Yanjun's avatar Zhu Yanjun Committed by Greg Kroah-Hartman
Browse files

RDMA/rxe: Fix the error caused by qp->sk 

[ Upstream commit 548ce2e66725dcba4e27d1e8ac468d5dd17fd509 ]

When sock_create_kern in the function rxe_qp_init_req fails,
qp->sk is set to NULL.

Then the function rxe_create_qp will call rxe_qp_do_cleanup
to handle allocated resource.

Before handling qp->sk, this variable should be checked.

Fixes: 8700e3e7 ("Soft RoCE driver")
Link: https://lore.kernel.org/r/20220822011615.805603-3-yanjun.zhu@linux.dev


Signed-off-by: default avatarZhu Yanjun <yanjun.zhu@linux.dev>
Reviewed-by: default avatarLi Zhijian <lizhijian@fujitsu.com>
Reviewed-by: default avatarBob Pearson <rpearsonhpe@gmail.com>
Signed-off-by: default avatarLeon Romanovsky <leon@kernel.org>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent 0d773c58

drivers/infiniband/sw/rxe/rxe_qp.c

+4 −2
Original line number Diff line number Diff line
@@ -847,9 +847,11 @@ static void rxe_qp_do_cleanup(struct work_struct *work) 


	free_rd_atomic_resources(qp);



	if (qp->sk) {

		kernel_sock_shutdown(qp->sk, SHUT_RDWR);

		sock_release(qp->sk);

	}

}



/* called when the last reference to the qp is dropped */

void rxe_qp_cleanup(struct rxe_pool_entry *arg)