Commit 7e68c0d0 authored Nov 21, 2022 by Zeng Heng Committed by Greg Kroah-Hartman Jan 18, 2023

PCI: Check for alloc failure in pci_request_irq()

[ Upstream commit 2d9cd957d40c3ac491b358e7cff0515bb07a3a9c ]

When kvasprintf() fails to allocate memory, it returns a NULL pointer.
Return error from pci_request_irq() so we don't dereference it.

[bhelgaas: commit log]
Fixes: 704e8953 ("PCI/irq: Add pci_request_irq() and pci_free_irq() helpers")
Link: https://lore.kernel.org/r/20221121020029.3759444-1-zengheng4@huawei.com


Signed-off-by: Zeng Heng <zengheng4@huawei.com>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent a234815c

drivers/pci/irq.c

+2 −0

Original line number	Diff line number	Diff line
		@@ -94,6 +94,8 @@ int pci_request_irq(struct pci_dev *dev, unsigned int nr, irq_handler_t handler,
		va_start(ap, fmt);
		devname = kvasprintf(GFP_KERNEL, fmt, ap);
		va_end(ap);
		if (!devname)
		return -ENOMEM;

		ret = request_threaded_irq(pci_irq_vector(dev, nr), handler, thread_fn,
		irqflags, devname, dev_id);