Commit 7e2a1083 authored Nov 12, 2009 by Julia Lawall Committed by Jiri Kosina Feb 04, 2010

fs/qnx4: decrement sizeof size in strncmp

As an identical match is wanted in this case, strcmp can be used instead.

The semantic match that lead to detecting this problem is as follows:
(http://coccinelle.lip6.fr/

)

// <smpl>
@@
expression foo;
constant char *abc;
@@

*strncmp(foo, abc, sizeof(abc))
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: Anders Larsen <al@alarsen.net>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>

parent fe9a2302

fs/qnx4/inode.c

+2 −1

Original line number	Diff line number	Diff line
		@@ -201,7 +201,8 @@ static const char qnx4_checkroot(struct super_block sb)
		rootdir = (struct qnx4_inode_entry ) (bh->b_data + i QNX4_DIR_ENTRY_SIZE);
		if (rootdir->di_fname != NULL) {
		QNX4DEBUG((KERN_INFO "rootdir entry found : [%s]\n", rootdir->di_fname));
		if (!strncmp(rootdir->di_fname, QNX4_BMNAME, sizeof QNX4_BMNAME)) {
		if (!strcmp(rootdir->di_fname,
		QNX4_BMNAME)) {
		found = 1;
		qnx4_sb(sb)->BitMap = kmalloc( sizeof( struct qnx4_inode_entry ), GFP_KERNEL );
		if (!qnx4_sb(sb)->BitMap) {