Commit 7e1ccd38 authored Feb 09, 2012 by Stephane Eranian Committed by Arnaldo Carvalho de Melo Feb 13, 2012

perf tools: cleanup initialization of attr->size

The perf_event_attr size needs to be initialized in all cases because it
captures the ABI version.

This patch moves the initialization of the field from the
perf_event_open() syscall stub to its proper location in the
event_attr_init().

Cc: Ingo Molnar <mingo@elte.hu>
Cc: Peter Zijlstra <peterz@infradead.org>
Link: http://lkml.kernel.org/r/20120209151238.GA10272@quad

Signed-off-by: Stephane Eranian <eranian@google.com>
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>

parent f1c67db7

tools/perf/perf.h

+0 −1

Original line number	Diff line number	Diff line
		@@ -167,7 +167,6 @@ sys_perf_event_open(struct perf_event_attr *attr,
		pid_t pid, int cpu, int group_fd,
		unsigned long flags)
		{
		attr->size = sizeof(*attr);
		return syscall(__NR_perf_event_open, attr, pid, cpu,
		group_fd, flags);
		}

tools/perf/util/util.c

+2 −0

Original line number	Diff line number	Diff line
		@@ -14,6 +14,8 @@ void event_attr_init(struct perf_event_attr *attr)
		attr->exclude_host = 1;
		if (!perf_guest)
		attr->exclude_guest = 1;
		/* to capture ABI version */
		attr->size = sizeof(*attr);
		}

		int mkdir_p(char *path, mode_t mode)