Commit 7de3e351 authored Aug 29, 2022 by Mateusz Kwiatkowski Committed by Greg Kroah-Hartman Oct 26, 2022

drm/vc4: vec: Fix timings for VEC modes



[ Upstream commit 30d7565be96b3946c18a1ce3fd538f7946839092 ]

This commit fixes vertical timings of the VEC (composite output) modes
to accurately represent the 525-line ("NTSC") and 625-line ("PAL") ITU-R
standards.

Previous timings were actually defined as 502 and 601 lines, resulting
in non-standard 62.69 Hz and 52 Hz signals being generated,
respectively.

Signed-off-by: Mateusz Kwiatkowski <kfyatek+publicgit@gmail.com>
Acked-by: Noralf Trønnes <noralf@tronnes.org>
Signed-off-by: Maxime Ripard <maxime@cerno.tech>
Link: https://patchwork.freedesktop.org/patch/msgid/20220728-rpi-analog-tv-properties-v2-28-459522d653a7@cerno.tech


Signed-off-by: Sasha Levin <sashal@kernel.org>

parent 8f6cad7c

drivers/gpu/drm/vc4/vc4_vec.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -256,7 +256,7 @@ static void vc4_vec_ntsc_j_mode_set(struct vc4_vec *vec)
		static const struct drm_display_mode ntsc_mode = {
		DRM_MODE("720x480", DRM_MODE_TYPE_DRIVER, 13500,
		720, 720 + 14, 720 + 14 + 64, 720 + 14 + 64 + 60, 0,
		480, 480 + 3, 480 + 3 + 3, 480 + 3 + 3 + 16, 0,
		480, 480 + 7, 480 + 7 + 6, 525, 0,
		DRM_MODE_FLAG_INTERLACE)
		};

		@@ -278,7 +278,7 @@ static void vc4_vec_pal_m_mode_set(struct vc4_vec *vec)
		static const struct drm_display_mode pal_mode = {
		DRM_MODE("720x576", DRM_MODE_TYPE_DRIVER, 13500,
		720, 720 + 20, 720 + 20 + 64, 720 + 20 + 64 + 60, 0,
		576, 576 + 2, 576 + 2 + 3, 576 + 2 + 3 + 20, 0,
		576, 576 + 4, 576 + 4 + 6, 625, 0,
		DRM_MODE_FLAG_INTERLACE)
		};