Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 7dbfdc23 authored by Ondrej Zary's avatar Ondrej Zary Committed by David S. Miller
Browse files

cx82310_eth: check usb_string() return value for error 



Fix that usb_string() return value is not checked for error (negative value).
Also change the ignore message a bit and lower its level to info.

Signed-off-by: default avatarOndrej Zary <linux@rainbow-software.org>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent d81e27cf

drivers/net/usb/cx82310_eth.c

+3 −5
Original line number Diff line number Diff line
@@ -138,11 +138,9 @@ static int cx82310_bind(struct usbnet *dev, struct usb_interface *intf) 
	struct usb_device *udev = dev->udev;



	/* avoid ADSL modems - continue only if iProduct is "USB NET CARD" */

	if (udev->descriptor.iProduct &&

	    usb_string(udev, udev->descriptor.iProduct, buf, sizeof(buf)) &&

	    strcmp(buf, "USB NET CARD")) {

		dev_err(&udev->dev,

			"probably an ADSL modem, use cxacru driver instead\n");

	if (usb_string(udev, udev->descriptor.iProduct, buf, sizeof(buf)) > 0

	    && strcmp(buf, "USB NET CARD")) {

		dev_info(&udev->dev, "ignoring: probably an ADSL modem\n");

		return -ENODEV;

	}