Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 7d76173d authored by Mateusz Kulikowski's avatar Mateusz Kulikowski Committed by Greg Kroah-Hartman
Browse files

staging: rtl8723au: Fix resource leak 



Firmware was not released properly if kmemdup fails.

Addresses-Coverity-Id: 1269118
Signed-off-by: default avatarMateusz Kulikowski <mateusz.kulikowski@gmail.com>
Acked-by: default avatarJes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 9da4aa48

drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c

+2 −2
Original line number Diff line number Diff line
@@ -249,13 +249,13 @@ int rtl8723a_FirmwareDownload(struct rtw_adapter *padapter) 
		goto Exit;

	}

	firmware_buf = kmemdup(fw->data, fw->size, GFP_KERNEL);

	fw_size = fw->size;

	release_firmware(fw);

	if (!firmware_buf) {

		rtStatus = _FAIL;

		goto Exit;

	}

	buf = firmware_buf;

	fw_size = fw->size;

	release_firmware(fw);



	/*  To Check Fw header. Added by tynli. 2009.12.04. */

	pFwHdr = (struct rt_8723a_firmware_hdr *)firmware_buf;