Commit 7d4f4075 authored Nov 05, 2021 by Josef Bacik Committed by Greg Kroah-Hartman Jan 27, 2022

btrfs: remove BUG_ON() in find_parent_nodes()



[ Upstream commit fcba0120edf88328524a4878d1d6f4ad39f2ec81 ]

We search for an extent entry with .offset = -1, which shouldn't be a
thing, but corruption happens.  Add an ASSERT() for the developers,
return -EUCLEAN for mortals.

Signed-off-by: Josef Bacik <josef@toxicpanda.com>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent ba72fa2c

fs/btrfs/backref.c

+6 −1

Original line number	Diff line number	Diff line
		@@ -1208,7 +1208,12 @@ static int find_parent_nodes(struct btrfs_trans_handle *trans,
		ret = btrfs_search_slot(trans, fs_info->extent_root, &key, path, 0, 0);
		if (ret < 0)
		goto out;
		BUG_ON(ret == 0);
		if (ret == 0) {
		/* This shouldn't happen, indicates a bug or fs corruption. */
		ASSERT(ret != 0);
		ret = -EUCLEAN;
		goto out;
		}

		#ifdef CONFIG_BTRFS_FS_RUN_SANITY_TESTS
		if (trans && likely(trans->type != __TRANS_DUMMY) &&