Commit 7d048df4 authored Nov 30, 2018 by Eric Sandeen Committed by Darrick J. Wong Dec 04, 2018

xfs: fix inverted return from xfs_btree_sblock_verify_crc



xfs_btree_sblock_verify_crc is a bool so should not be returning
a failaddr_t; worse, if xfs_log_check_lsn fails it returns
__this_address which looks like a boolean true (i.e. success)
to the caller.

(interestingly xfs_btree_lblock_verify_crc doesn't have the issue)

Signed-off-by: Eric Sandeen <sandeen@redhat.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>

parent a579121f

fs/xfs/libxfs/xfs_btree.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -330,7 +330,7 @@ xfs_btree_sblock_verify_crc(

		if (xfs_sb_version_hascrc(&mp->m_sb)) {
		if (!xfs_log_check_lsn(mp, be64_to_cpu(block->bb_u.s.bb_lsn)))
		return __this_address;
		return false;
		return xfs_buf_verify_cksum(bp, XFS_BTREE_SBLOCK_CRC_OFF);
		}