Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 7ce6c65b authored by Jarkko Nikula's avatar Jarkko Nikula Committed by Wolfram Sang
Browse files

i2c: sh_mobile: Remove dummy runtime PM callbacks 



Platform drivers don't need dummy runtime PM callbacks that just return
success and non-NULL pm pointer in their struct device_driver in order
to have runtime PM happening. This has changed since following commits:

05aa55dd ("PM / Runtime: Lenient generic runtime pm callbacks")
543f2503 ("PM / platform_bus: Allow runtime PM by default")
8b313a38 ("PM / Platform: Use generic runtime PM callbacks directly")

Signed-off-by: default avatarJarkko Nikula <jarkko.nikula@linux.intel.com>
Reviewed-by: default avatarWolfram Sang <wsa+renesas@sang-engineering.com>
Signed-off-by: default avatarWolfram Sang <wsa@the-dreams.de>
parent eaba6878

drivers/i2c/busses/i2c-sh_mobile.c

+0 −18
Original line number Diff line number Diff line
@@ -947,27 +947,9 @@ static int sh_mobile_i2c_remove(struct platform_device *dev) 
	return 0;

}



static int sh_mobile_i2c_runtime_nop(struct device *dev)

{

	/* Runtime PM callback shared between ->runtime_suspend()

	 * and ->runtime_resume(). Simply returns success.

	 *

	 * This driver re-initializes all registers after

	 * pm_runtime_get_sync() anyway so there is no need

	 * to save and restore registers here.

	 */

	return 0;

}



static const struct dev_pm_ops sh_mobile_i2c_dev_pm_ops = {

	.runtime_suspend = sh_mobile_i2c_runtime_nop,

	.runtime_resume = sh_mobile_i2c_runtime_nop,

};



static struct platform_driver sh_mobile_i2c_driver = {

	.driver		= {

		.name		= "i2c-sh_mobile",

		.pm		= &sh_mobile_i2c_dev_pm_ops,

		.of_match_table = sh_mobile_i2c_dt_ids,

	},

	.probe		= sh_mobile_i2c_probe,