Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 7cdfa442 authored by David Howells's avatar David Howells Committed by Al Viro
Browse files

vfs: Fix refcounting of filenames in fs_parser 



Fix an overput in which filename_lookup() unconditionally drops a ref to
the filename it was given, but this isn't taken account of in the caller,
fs_lookup_param().

Addresses-Coverity-ID: 1443811 ("Use after free")
Signed-off-by: default avatarDavid Howells <dhowells@redhat.com>
parent c3aabf07

fs/fs_parser.c

+1 −0
Original line number Diff line number Diff line
@@ -268,6 +268,7 @@ int fs_lookup_param(struct fs_context *fc, 
		return invalf(fc, "%s: not usable as path", param->key);

	}



	f->refcnt++; /* filename_lookup() drops our ref. */

	ret = filename_lookup(param->dirfd, f, flags, _path, NULL);

	if (ret < 0) {

		errorf(fc, "%s: Lookup failure for '%s'", param->key, f->name);