Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 7cce8e4e authored by Dan Carpenter's avatar Dan Carpenter Committed by Rob Clark
Browse files

drm/msm: fix an error code in the ioctl 



The copy_to/from_user() functions return the number of bytes remaining
to be copied but we should return -EFAULT to the user.

Fixes: f05c83e7 ("drm/msm: add uapi to get/set debug name")
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarRob Clark <robdclark@gmail.com>
parent b6bd458c

drivers/gpu/drm/msm/msm_drv.c

+6 −4
Original line number Diff line number Diff line
@@ -851,8 +851,9 @@ static int msm_ioctl_gem_info(struct drm_device *dev, void *data, 
			ret = -EINVAL;

			break;

		}

		ret = copy_from_user(msm_obj->name,

			u64_to_user_ptr(args->value), args->len);

		if (copy_from_user(msm_obj->name, u64_to_user_ptr(args->value),

				   args->len))

			ret = -EFAULT;

		msm_obj->name[args->len] = '\0';

		for (i = 0; i < args->len; i++) {

			if (!isprint(msm_obj->name[i])) {
@@ -868,8 +869,9 @@ static int msm_ioctl_gem_info(struct drm_device *dev, void *data, 
		}

		args->len = strlen(msm_obj->name);

		if (args->value) {

			ret = copy_to_user(u64_to_user_ptr(args->value),

					msm_obj->name, args->len);

			if (copy_to_user(u64_to_user_ptr(args->value),

					 msm_obj->name, args->len))

				ret = -EFAULT;

		}

		break;

	}