Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 7cc61694 authored by Nir Dotan's avatar Nir Dotan Committed by David S. Miller
Browse files

mlxsw: core_acl_flex_actions: Remove redundant counter destruction 



Each tc flower rule uses a hidden count action. As counter resource may
not be available due to limited HW resources, update _counter_create()
and _counter_destroy() pair to follow previously introduced symmetric
error condition handling, add a call to mlxsw_afa_resource_del() as part
of the counter resource destruction.

Fixes: c18c1e18 ("mlxsw: core: Make counter index allocated inside the action append")
Signed-off-by: default avatarNir Dotan <nird@mellanox.com>
Reviewed-by: default avatarPetr Machata <petrm@mellanox.com>
Reviewed-by: default avatarJiri Pirko <jiri@mellanox.com>
Signed-off-by: default avatarIdo Schimmel <idosch@mellanox.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent dda0a3a3

drivers/net/ethernet/mellanox/mlxsw/core_acl_flex_actions.c

+1 −0
Original line number Diff line number Diff line
@@ -584,6 +584,7 @@ static void 
mlxsw_afa_counter_destroy(struct mlxsw_afa_block *block,

			  struct mlxsw_afa_counter *counter)

{

	mlxsw_afa_resource_del(&counter->resource);

	block->afa->ops->counter_index_put(block->afa->ops_priv,

					   counter->counter_index);

	kfree(counter);