Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 7cbcf5fe authored by Su Hui's avatar Su Hui Committed by Greg Kroah-Hartman
Browse files

wifi: rtlwifi: add calculate_bit_shift() 



[ Upstream commit 52221dfddbbfb5b4e029bb2efe9bb7da33ec1e46 ]

There are many same functions like _rtl88e_phy_calculate_bit_shift(),
_rtl92c_phy_calculate_bit_shift() and so on. And these functions can
cause undefined bitwise shift behavior. Add calculate_bit_shift() to
replace them and fix undefined behavior in subsequent patches.

Signed-off-by: default avatarSu Hui <suhui@nfschina.com>
Acked-by: default avatarPing-Ke Shih <pkshih@realtek.com>
Signed-off-by: default avatarKalle Valo <kvalo@kernel.org>
Link: https://msgid.link/20231219065739.1895666-2-suhui@nfschina.com


Stable-dep-of: 969bc926f04b ("wifi: rtlwifi: rtl8188ee: phy: using calculate_bit_shift()")
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent 4985e507

drivers/net/wireless/realtek/rtlwifi/wifi.h

+7 −0
Original line number Diff line number Diff line
@@ -3230,4 +3230,11 @@ static inline struct ieee80211_sta *rtl_find_sta(struct ieee80211_hw *hw, 
	return ieee80211_find_sta(mac->vif, mac_addr);

}



static inline u32 calculate_bit_shift(u32 bitmask)

{

	if (WARN_ON_ONCE(!bitmask))

		return 0;



	return __ffs(bitmask);

}

#endif