NFS: Fix a reference and lock leak in nfs_lock_and_join_requests()



Yes, this is a situation that should never happen (hence the WARN_ON)
but we should still ensure that we free up the locks and references to
the faulty pages.

Signed-off-by: Trond Myklebust <trond.myklebust@primarydata.com>

parent 08fead2a

fs/nfs/write.c

+1 −2

Original line number	Diff line number	Diff line
		@@ -526,8 +526,7 @@ nfs_lock_and_join_requests(struct page *page)
		} else if (WARN_ON_ONCE(subreq->wb_offset < head->wb_offset \|\|
		((subreq->wb_offset + subreq->wb_bytes) >
		(head->wb_offset + total_bytes)))) {
		nfs_page_group_unlock(head);
		spin_unlock(&inode->i_lock);
		nfs_unroll_locks_and_wait(inode, head, subreq);
		return ERR_PTR(-EIO);
		}