Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 7caff66f authored Jan 06, 2014 by Daniel Lezcano Committed by Ingo Molnar Jan 13, 2014

sched: Reduce trigger_load_balance() parameters



The cpu information is already stored in the struct rq, so no need to pass it
as parameter to the trigger_load_balance function.

Cc: linaro-kernel@lists.linaro.org
Cc: preeti.lkml@gmail.com
Cc: mingo@redhat.com
Cc: peterz@infradead.org
Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
Signed-off-by: Peter Zijlstra <peterz@infradead.org>
Link: http://lkml.kernel.org/r/1389008085-9069-2-git-send-email-daniel.lezcano@linaro.org


Signed-off-by: Ingo Molnar <mingo@kernel.org>

parent de212f18

kernel/sched/core.c

+1 −1

Original line number	Original line	Diff line number	Diff line
	@@ -2436,7 +2436,7 @@ void scheduler_tick(void)

	#ifdef CONFIG_SMP		#ifdef CONFIG_SMP
	rq->idle_balance = idle_cpu(cpu);		rq->idle_balance = idle_cpu(cpu);
	trigger_load_balance(rq, cpu);		trigger_load_balance(rq);
	#endif		#endif
	rq_last_tick_reset(rq);		rq_last_tick_reset(rq);
	}		}

kernel/sched/fair.c

+3 −1

Original line number	Original line	Diff line number	Diff line
	@@ -6876,8 +6876,10 @@ static inline int on_null_domain(int cpu)
	/*		/*
	* Trigger the SCHED_SOFTIRQ if it is time to do periodic load balancing.		* Trigger the SCHED_SOFTIRQ if it is time to do periodic load balancing.
	*/		*/
	void trigger_load_balance(struct rq *rq, int cpu)		void trigger_load_balance(struct rq *rq)
	{		{
			int cpu = rq->cpu;

	/* Don't need to rebalance while attached to NULL domain */		/* Don't need to rebalance while attached to NULL domain */
	if (time_after_eq(jiffies, rq->next_balance) &&		if (time_after_eq(jiffies, rq->next_balance) &&
	likely(!on_null_domain(cpu)))		likely(!on_null_domain(cpu)))

kernel/sched/sched.h

+1 −1

Original line number	Original line	Diff line number	Diff line
	@@ -1175,7 +1175,7 @@ extern const struct sched_class idle_sched_class;

	extern void update_group_power(struct sched_domain *sd, int cpu);		extern void update_group_power(struct sched_domain *sd, int cpu);

	extern void trigger_load_balance(struct rq *rq, int cpu);		extern void trigger_load_balance(struct rq *rq);
	extern void idle_balance(int this_cpu, struct rq *this_rq);		extern void idle_balance(int this_cpu, struct rq *this_rq);

	extern void idle_enter_fair(struct rq *this_rq);		extern void idle_enter_fair(struct rq *this_rq);