crypto.h: remove unused crypto_tfm_alg_modname() inline (7c926402) · Commits · e / devices / android_kernel_fairphone_FP5

The <linux/crypto.h> (which is in turn in common headers like tcp.h) wants to use module_name() in an inline fcn. But having all of <linux/module.h> along for the ride is overkill and slows down compiles by a measureable amount, since it in turn includes lots of headers. Since the inline is never used anywhere in the kernel[1], we can just remove it, and then also remove the module.h include as well. In all the many crypto modules, there were some relying on crypto.h including module.h -- for them we now explicitly call out module.h for inclusion. [1] git grep shows some staging drivers also define the same static inline, but they also never ever use it. Signed-off-by:

Paul Gortmaker <paul.gortmaker@windriver.com>

include/linux/crypto.h

+0 −6

Original line number	Original line	Diff line number	Diff line
	@@ -18,7 +18,6 @@
	#define _LINUX_CRYPTO_H		#define _LINUX_CRYPTO_H

	#include <linux/atomic.h>		#include <linux/atomic.h>
	#include <linux/module.h>
	#include <linux/kernel.h>		#include <linux/kernel.h>
	#include <linux/list.h>		#include <linux/list.h>
	#include <linux/slab.h>		#include <linux/slab.h>
	@@ -505,11 +504,6 @@ static inline int crypto_tfm_alg_priority(struct crypto_tfm *tfm)
	return tfm->__crt_alg->cra_priority;		return tfm->__crt_alg->cra_priority;
	}		}

	static inline const char crypto_tfm_alg_modname(struct crypto_tfm tfm)
	{
	return module_name(tfm->__crt_alg->cra_module);
	}

	static inline u32 crypto_tfm_alg_type(struct crypto_tfm *tfm)		static inline u32 crypto_tfm_alg_type(struct crypto_tfm *tfm)
	{		{
	return tfm->__crt_alg->cra_flags & CRYPTO_ALG_TYPE_MASK;		return tfm->__crt_alg->cra_flags & CRYPTO_ALG_TYPE_MASK;