Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 7c8df6fa authored by Miaoqian Lin's avatar Miaoqian Lin Committed by Greg Kroah-Hartman
Browse files

net: dsa: lantiq_gswip: Fix refcount leak in gswip_gphy_fw_list 



[ Upstream commit 0737e018a05e2aa352828c52bdeed3b02cff2930 ]

Every iteration of for_each_available_child_of_node() decrements
the reference count of the previous node.
when breaking early from a for_each_available_child_of_node() loop,
we need to explicitly call of_node_put() on the gphy_fw_np.
Add missing of_node_put() to avoid refcount leak.

Fixes: 14fceff4 ("net: dsa: Add Lantiq / Intel DSA driver for vrx200")
Signed-off-by: default avatarMiaoqian Lin <linmq006@gmail.com>
Link: https://lore.kernel.org/r/20220605072335.11257-1-linmq006@gmail.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent e412b3d1

drivers/net/dsa/lantiq_gswip.c

+3 −1
Original line number Diff line number Diff line
@@ -1958,8 +1958,10 @@ static int gswip_gphy_fw_list(struct gswip_priv *priv, 
	for_each_available_child_of_node(gphy_fw_list_np, gphy_fw_np) {

		err = gswip_gphy_fw_probe(priv, &priv->gphy_fw[i],

					  gphy_fw_np, i);

		if (err)

		if (err) {

			of_node_put(gphy_fw_np);

			goto remove_gphy;

		}

		i++;

	}